Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry pick the migration sql #18644

Merged
merged 1 commit into from
May 10, 2023
Merged

fix: cherry pick the migration sql #18644

merged 1 commit into from
May 10, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented May 8, 2023 •
edited
Loading

Cherry pick the migration SQL of 2.8.1 to main branch.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added the release-note/update Update or Fix label May 8, 2023
@chlins chlins requested a review from a team as a code owner May 8, 2023 01:07
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Merging #18644 (51b6d4c) into main (36c2b93) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18644   +/-   ##
=======================================
  Coverage   67.38%   67.39%           
=======================================
  Files         984      984           
  Lines      107029   107029           
  Branches     2670     2670           
=======================================
+ Hits        72120    72127    +7     
+ Misses      31026    31020    -6     
+ Partials     3883     3882    -1
Flag Coverage Δ
unittests 67.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@chlins chlins force-pushed the perf/cherry-pick-artifact-sql branch from 1181eb8 to bb2aebc Compare May 9, 2023 09:54
@chlins
fix: cherry pick the migration sql
51b6d4c 
Cherry pick the migration SQL of 2.8.1 to main branch.

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins force-pushed the perf/cherry-pick-artifact-sql branch from bb2aebc to 51b6d4c Compare May 10, 2023 07:39
wy65701436
wy65701436 approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 2958d7b into goharbor:main May 10, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
@chlins @WilfredAlmeida
fix: cherry pick the migration sql (goharbor#18644)
a5feb87 
Cherry pick the migration SQL of 2.8.1 to main branch.

Signed-off-by: chlins <chenyuzh@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
@chlins @WilfredAlmeida
fix: cherry pick the migration sql (goharbor#18644)
5b54be8 
Cherry pick the migration SQL of 2.8.1 to main branch.

Signed-off-by: chlins <chenyuzh@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@stonezdj stonezdj

@wy65701436 wy65701436

@zyyw zyyw

@MinerYang MinerYang

Labels
release-note/update Update or Fix target/2.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chlins @wy65701436 @YangJiao0817 @stonezdj @zyyw @MinerYang